search

ygrek / mldonkey

cross-platform multi-network p2p daemon
http://mldonkey.sourceforge.net/
Other
235 stars 43 forks source link

UPNP build error #101

Open ogarcia opened 3 weeks ago

ogarcia commented 3 weeks ago

Arch Linux with libnatpmp-20230423-2 and miniupnpc-2.2.8-1:

src/utils/net/upnp_stubs.c: In function ‘upnpPulse’:
src/utils/net/upnp_stubs.c:659:41: error: too few arguments to function ‘UPNP_GetValidIGD’
  659 |         if( UPNP_IGD_VALID_CONNECTED == UPNP_GetValidIGD( devlist, &map->upnpUrls, &map->upnpData,
      |                                         ^~~~~~~~~~~~~~~~

This problem occurred after upgrading miniupnpc from 2.2.7-2 to 2.2.8-1 so the culprit is this update.

FabioLolix commented 2 weeks ago

In the Arch AUR pkgbuild the problem is avoided using

sed -i 's/sizeof( map->lanaddr )/sizeof( map->lanaddr ), NULL , 0/g' src/utils/net/upnp_stubs.c

as suggested here