Open barracuda156 opened 2 months ago
yes, but the patch is not good, for different people path will be different. It should use ocamlfind to find deps.
I know, that is why I did not submit it as a PR.
This will be for the next release. Documented current gui build status in https://github.com/ygrek/mldonkey/commit/16e410632d7138bd0485e0d399ffd4aded6c9b69
@ygrek Hmm, somehow this got further broken in 3.2.1, since the patch that worked earlier has no effect now. Not yet sure what went wrong.
Ah, perhaps just this: https://github.com/ygrek/mldonkey/commit/da5db5087a8d07c1eaf3cc53d479c1cc59740cf1
I.e. I applied the patch to configure.in
, but it is not used now :)
UPD. Yeah, indeed. I just need to patch configure now.
However, this error https://github.com/ygrek/mldonkey/issues/111 is still there, so GTK GUI does not build:
ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60-70 -I src/utils/extlib -I src/utils/cdk -I src/utils/bitstring -I src/utils/lib -I src/utils/ocamlrss -I src/utils/xml-light -I src/utils/net -I tools -I src/daemon/common -I src/daemon/driver -I src/utils/mp3tagui -I src/config/unix -I src/gtk2/gui -I src/gtk2/gui/x11 -I src/gtk2/gui/win32 -I icons/rsvg -I +lablgtk2 -I src/networks/direct_connect -I src/networks/fasttrack -I src/networks/fileTP -I src/networks/bittorrent -I src/networks/donkey -I +camlp4 -I /opt/local/lib/ocaml/site-lib/num -c src/gtk2/gui/guiUtf8.ml
File "src/gtk2/gui/guiUtf8.ml", line 180, characters 19-43:
180 | let (_, charset) = Glib.Convert.get_charset ()
^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound module Glib
gmake: *** [Makefile:5443: src/gtk2/gui/guiUtf8.cmo] Error 2
gmake: Leaving directory '/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_net_mldonkey/mldonkey/work/mldonkey-3-2-1'
Command failed: cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_net_mldonkey/mldonkey/work/mldonkey-3-2-1" && /opt/local/bin/gmake -w all
Exit code: 2
UPD. Yeah, indeed. I just need to patch configure now.
patch configure.in and do cd config && autoconf
unbound module glib means path to gtk is not correct i assume
@ygrek I have found a reason why
lablgtk2
is not found. It sits in/opt/local/lib/ocaml/site-lib/lablgtk2
, but configure uses$OCAMLLIB/$LABLGTK_NAME
, whereOCAMLLIB
is defined byocamlc -where
, which gives/opt/local/lib/ocaml
. Of course, having the path wrong, configure cannot find it.This works correctly:
After the patch applied, configure finds what it should: