search

ygrek / mldonkey

cross-platform multi-network p2p daemon (previously at http://mldonkey.sourceforge.net/)
Other
257 stars 46 forks source link

GTK2 build: error when compiling `guiUtf8.ml`: `Unbound module Glib` #111

Closed barracuda156 closed 3 months ago

barracuda156 commented 3 months ago 
ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60-70   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11  -I src/gtk2/gui/win32  -I icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect  -I src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4 -I /opt/local/lib/ocaml/site-lib/num -c src/gtk2/gui/guiUtf8.mli
ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60-70   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11  -I src/gtk2/gui/win32  -I icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect  -I src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4 -I /opt/local/lib/ocaml/site-lib/num -c src/gtk2/gui/guiUtf8.ml
File "src/gtk2/gui/guiUtf8.ml", line 180, characters 19-43:
180 | let (_, charset) = Glib.Convert.get_charset ()
                         ^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound module Glib
gmake: *** [Makefile:5447: src/gtk2/gui/guiUtf8.cmo] Error 2

@ygrek Could you suggest what may be going wrong here?

Single-core build, and I have rebuilt lablgtk2 just in case (same error before and after).

barracuda156 commented 3 months ago

Non-GUI build looks fine though:

mldonkey

ygrek commented 3 months ago

show full configure and build log (always when reporting build errors)

afaik currently newgui2 build is working only with lablgtk2 downloaded and built by configure. If you installed lablgtk2 separately (via system packages or via opam) then it will not work (but it shouldn't be even detected, so idk what is your specific problem here) I have a wip patch to make it work with opam packaged lablgtk2 but it will have to wait after the release of current state.

lulol commented 3 months ago

afaik currently newgui2 build is working only with lablgtk2 downloaded and built by configure. If you installed lablgtk2 separately (via system packages or via opam) then it will not work (but it shouldn't be even detected, so idk what is your specific problem here)

@ygrek newgui2 build works with the ubuntu packaged lablgtk2-2.18.12-1 and is detected, as previously reported. https://github.com/ygrek/mldonkey/pull/99#issuecomment-2266193683

The AppImageBuilder PR https://github.com/ygrek/mldonkey/pull/80 workflow builds mlnet, mlgui and mlnet+gui on ubuntu-22.04 and package mlnet+gui (with 20.04 also worked IIRC). The resulting app seems to run fine, although didn't try to download any file, just connect to servers, some searches and check logs.

What newgui2 build is not working?

barracuda156 commented 3 months ago

show full configure and build log (always when reporting build errors)

afaik currently newgui2 build is working only with lablgtk2 downloaded and built by configure. If you installed lablgtk2 separately (via system packages or via opam) then it will not work (but it shouldn't be even detected, so idk what is your specific problem here)

I have a wip patch to make it work with opam packaged lablgtk2 but it will have to wait after the release of current state.

I have fixed the detection: configure simply looks into a wrong path using a wrong lib name. See the related issue.

Since we have lablgtk2 in MacPorts, it is undesirable to build a duplicate. What is specifically the issue, why externally built lib fails with mldonkey? That should not be the case: whatever we have OCaml in MacPorts uses our libs, everything works. If the upstream lablgtk2 has a bug which you fix locally, then we can borrow a patch to use for our port.

P. S. I will share the log tomorrow, away from the PowerMac now, and do not have prerequisites to build this on another machine.

ygrek commented 3 months ago

Oh yes, I stand corrected, it builds with debian packaged lablgtk2. The bug is in mldonkey build scripts, too much assumptions that don't hold anymore. Documented what I figured in README. Continue in #107 . Will not delay release for newgui2 issues, will target in next release.