Do not hardcode ocaml/lablgtk dependencies

ygrek / mldonkey

cross-platform multi-network p2p daemon (previously at http://mldonkey.sourceforge.net/)

Other

240 stars 45 forks source link

Do not hardcode ocaml/lablgtk dependencies #14

Closed anatol closed 4 years ago

anatol commented 8 years ago

MLDonkey build system hardcodes dependencies to some specific versions.

Different OS' and distros have different versions and MLDonkey should not force users downgrade system compiler. Instead project should work with system compiler. For example Arch system versions are: ocaml - 4.02.3 lablgtk2 - 2.18.3

anatol commented 8 years ago

Also MLDonkey carries patches for the old ocaml problem that has been fixed 5 years ago. http://caml.inria.fr/mantis/view.php?id=5237

It does not make sense to me.

ygrek commented 8 years ago

How it worked previously - a branch from this repo was cherry-picked into upstream cvs periodically and then release was made from cvs. And all this versioning stuff was taken care by upstream. Probably we need to modernize this, but it will be backwards incompatible (i.e. change build procedure - say switch to opam and raise minimum OCaml version - that's what I'd like to do)

ygrek commented 8 years ago

BTW can you provide the log when this happens, because afaics the script doesn't require hardcoded versions, but it will propose hardcoded versions if the installed one don't work (or the test is broken, see #18)