Finishing Code

[PeterPilley]

ygrek I note in your code it looks like you have not finished all parts of this api, is it possible to finish?

I have an ongoing project that I am trying to base on mldonkey and your json additions could be really useful but I would like to expose all functions. Are you still developing this?

[ygrek]

It is definitely possible. I need feedback on the existing api and what parts do you need most at this point. Also be ready that some things might change, no compatibility guarantee for now.

[PeterPilley]

OKay I will start testing and respond back.

So from the API I can see that the search function, download functions have been exposed unless I missed any other functions.

Can you expose the settings functions?

Are all functions exposed in the API file or are the in the driverInteractive file?

[ygrek]

Noted. Everything is in src/daemon/driver/driverApi.ml Also there is docs/api.md

[PeterPilley]

The api listens on a seperate interface port correct?

Where is this established

Can you expose the upload functions ie the show uploaders details

For the searches it looks like you have to specify the item to download there is no /all/ option unless I missed it

Have api running now, I am keen to write up the documentation as well if your happy.

[ygrek]

It listens on the same port as webui - see https://github.com/ygrek/mldonkey/blob/api/docs/api.md Why would anyone want to download all search results? Anyway via api just going through all results and issuing separate request for each should work

[PeterPilley]

Okay have tested the api over the weekend very nice, I am adding the downloaders function and it is called from driverCommands.ml I am not a caml dev can you give some advise

[PeterPilley]

so for me the functions I would like to expose from the original web interface would be the

• vc or view clients option this looks to be called from commonClient as clients_get_all() and seems to expose both the uploaders and the downloaders functions. By default it is vc all from the telnet interface and that is treated as an argument. it would be awesome to be able to expose the entire function and be able to expose the vc [num] where you can see an individual source data

is this possible?

[ygrek]

see example at https://github.com/ygrek/mldonkey/commit/8dceb41fe71c1c040208d40d44a2104db694e125

[PeterPilley]

Thanks, Testing now.

Okay that looks cool I just noticed that the text version also calls client_print_info

Printf.bprintf buf "[%s%6d] Name  : %-27s Rating  : %-10d  IP   : %-20s"
        n.network_name
        (client_num c)
        (shorten info.G.client_name 20)
        info.GuiTypes.client_rating
        (match info.G.client_kind with
              Indirect_location (_, _, ip, port)
            | Known_location (ip, port) ->
                Printf.sprintf "%s:%d" (Ip.to_string ip) port)

Is it just a matter of updating the atd file with the additional data I am after the ip and port information and geolocation data.

[PeterPilley]

Have country code and IP exposed now, thanks for example.

Could the downloads call be modified to specify a specific user to download from?

[ygrek]

Have country code and IP exposed now, thanks for example.

Do you mean you have added it? Please share the patch/branch/PR.

Could the downloads call be modified to specify a specific user to download from?

I don't quite understand the question, what do you have in mind?

[PeterPilley]

do you have an email to enable easier discussion

[ygrek]

See email in commits. Also there is #mldonkey irc on freenode.

[PeterPilley]

Okay sure I will go through the commits.

[PeterPilley]

Have sent email did you get it?

I am looking at the new clients call that you did can you advise on how to include the results from donkeyinteractive or any of the interactives.

Specifically I need to associate the client with the downloading file I thought it was the file_queue that you have as queue_length but I cant see it there, and I want to expost the client MD4 (will try and do the same for the gnutellainteractive as well).

Also is it possible for the search results to show who the result is coming from like in gnutella you have the locations stored within remotefiledesc as well as the alt locations. can results.json contain an array of the result locations?