search

ygrek / mldonkey

cross-platform multi-network p2p daemon (previously at http://mldonkey.sourceforge.net/)
Other
240 stars 45 forks source link

mldonkey don't build with miniupnpc 1.8 #3

Closed sl1pkn07 closed 10 years ago

sl1pkn07 commented 10 years ago

when build with system miniupnpc 1.8:

http://sl1pkn07.no-ip.com/paste/view/07ac8836

use archlinux

./configure --prefix=/usr --enable-minimum --enable-upnp-natpmp --enable-bzip2 --enable-magic --enable-donkeysui

another tip:

git describe --long --tags show: release-3-1-0-259-g6102a4b

but the program version is 3.1.3

greetings

ygrek commented 10 years ago

AFACS mldonkey builds fine with miniupnpc 1.8 Error message suggests that you are using very old libnatpmp, please try the latest version (it is separate from miniupnpc), e.g. http://miniupnp.free.fr/files/download.php?file=libnatpmp-20131126.tar.gz

Concerning the second problem - I've just pushed the missing tags, thanks!

sl1pkn07 commented 10 years ago

I make a little hack to build with use "--enable-force-upnp-natpmp" with latest version of libnatpmp/miniupnpc

http://miniupnp.free.fr/files/download.php?file=miniupnpc-1.8.20131209.tar.gz http://miniupnp.free.fr/files/download.php?file=libnatpmp-20131126.tar.gz

  sed -e 's|libnatpmp-20110808|libnatpmp-20131126|g' \
      -e 's|miniupnpc-1.6|miniupnpc-1.8.20131209|g' -i config/configure.in

with this, build OK

but if use same version installed from distribution package (without --enable-force-upnp-natpmp)

https://www.archlinux.org/packages/community/x86_64/miniupnpc/ https://aur.archlinux.org/packages/libnatpmp/ (this i've modify to use latest version instead 2012)

Fail build

the only difference is, by default, arch strip all binaries

└───╼  md5sum /usr/lib/libnatpmp.so.1
b3abcb8ea4caa13a0ea7ef9b04f44a18  /usr/lib/libnatpmp.so.1

└───╼  md5sum /home/sl1pkn07/aplicaciones/mldonkey-daemon-cvs/src/mldonkey/patches/local/usr/lib/libnatpmp.so.1
c20501633f8470e925dbe5ee28b669ca  /home/sl1pkn07/aplicaciones/mldonkey-daemon-cvs/src/mldonkey/patches/local/usr/lib/libnatpmp.so.1

└───╼  md5sum /usr/lib/libminiupnpc.so.9
e209d71e647833906f7abbfb42300a63  /usr/lib/libminiupnpc.so.9

└───╼  md5sum /home/sl1pkn07/aplicaciones/mldonkey-daemon-cvs/src/mldonkey/patches/local/usr/lib/libminiupnpc.so.9
72c0098e974a3872ea49ffd56efb5ba7  /home/sl1pkn07/aplicaciones/mldonkey-daemon-cvs/src/mldonkey/patches/local/usr/lib/libminiupnpc.so.9

I test build by myself these libs without strip binaries

└───╼  md5sum /usr/lib/libnatpmp.so.1
c20501633f8470e925dbe5ee28b669ca  /usr/lib/libnatpmp.so.1

└───╼  md5sum /home/sl1pkn07/aplicaciones/mldonkey-daemon-cvs/src/mldonkey/patches/local/usr/lib/libnatpmp.so.1
c20501633f8470e925dbe5ee28b669ca  /home/sl1pkn07/aplicaciones/mldonkey-daemon-cvs/src/mldonkey/patches/local/usr/lib/libnatpmp.so.1

└───╼  md5sum /usr/lib/libminiupnpc.so.9
72c0098e974a3872ea49ffd56efb5ba7  /usr/lib/libminiupnpc.so.9

└───╼  md5sum /home/sl1pkn07/aplicaciones/mldonkey-daemon-cvs/src/mldonkey/patches/local/usr/lib/libminiupnpc.so.9
72c0098e974a3872ea49ffd56efb5ba7  /home/sl1pkn07/aplicaciones/mldonkey-daemon-cvs/src/mldonkey/patches/local/usr/lib/libminiupnpc.so.9

but still fail build (same error like first post)

why?

ygrek commented 10 years ago

Please provide more information. Show the ./configure arguments and output, show the make output. Ensure that you don't have leftover include files for the old version of libnatpmp.

sl1pkn07 commented 10 years ago

ok, i found my problem :(

yes i have leftover includes from very older libnatpmp

sanity my include path (remove /usr/include/natpmp.h) and build system libnatpmp with corret include path (before includes store in /usr/include/libnatpmp instead /usr/include)

all build OK and detected by configure

----- checking libminiupnpc >= 1.8.20131209 (optional)
checking miniupnpc/miniupnpc.h usability... yes
checking miniupnpc/miniupnpc.h presence... yes
checking for miniupnpc/miniupnpc.h... yes
checking for upnpDiscover in -lminiupnpc... yes
----- checking libnatpmp >= 20131126 (optional)
checking natpmp.h usability... yes
checking natpmp.h presence... yes
checking for natpmp.h... yes
checking for initnatpmp in -lnatpmp... yes

you can safe change library version in

https://github.com/ygrek/mldonkey/blob/next/config/configure.in#L868 https://github.com/ygrek/mldonkey/blob/next/config/configure.in#L888 https://github.com/ygrek/mldonkey/blob/next/config/configure.in#L893

greetings and sorry

close issue

sl1pkn07 commented 10 years ago

hi, reopened again

same error (same output, see first post) with miniupnpc 1.9

installing miniupnpc 1.8 build again

no new version of libpmpnat since 20131126

this time no have leftover files

greetings

ygrek commented 10 years ago

Fixed 03896bf, thanks!