search

ygrek / mldonkey

cross-platform multi-network p2p daemon (previously at http://mldonkey.sourceforge.net/)
Other
240 stars 45 forks source link

please port from Camlp4 to Camlp5 #36

Open rosset opened 5 years ago

rosset commented 5 years ago

please port from Camlp4 to Camlp5

XVilka commented 5 years ago

Note, that Camlp4 is deprecated officially now, and 4.08 version will be the last one: https://discuss.ocaml.org/t/the-end-of-camlp4/4216

It is advised to switch to extension points (ppx) instead.

XVilka commented 4 years ago

Btw, it will not work with 4.09 without this port.

HinTak commented 4 years ago

Fedora 32 ships caml 4.10, and camlp4 is gone...

ygrek commented 4 years ago

@HinTak https://github.com/camlp4/camlp4 works for 4.10, I will do a release soon. So far it seems easier to keep camlp4 updated.

HinTak commented 4 years ago

@ygrek if mldonkey can be changed to download just that? I expect newer linux distro will do similar - ships 4.10 with p5...

ygrek commented 4 years ago

longterm I hope to be able to use opam bundle

ygrek commented 4 years ago

fwiw camlp4 4.10 was released https://github.com/camlp4/camlp4/releases/tag/4.10%2B1

XVilka commented 4 years ago

Should it be closed then?

HinTak commented 4 years ago

It would still be nice for mldonkey to only download comlp4 and rebuild that against newer caml though!