search

ygrek / mldonkey

cross-platform multi-network p2p daemon (previously at http://mldonkey.sourceforge.net/)
Other
258 stars 46 forks source link

Commit 0ee9f8d87f9b970e463b8bb13d11a778d27ad96d breaks compiling on Ubuntu 22.04 #89

Closed Compiler11 closed 4 months ago

Compiler11 commented 1 year ago

I ran a git bisect and it came up with this commit which breaks the compile:

Configuring MLDonkey 3.1.7.git - SCM: release-3-1-7-2-12-g0ee9f8d8 completed.

Network modules:
 - eDonkey           enabled (eMule SUI enabled)
 - BitTorrent        enabled
 - FileTP (aka wget)         disabled
 - Fasttrack                 disabled
 - Gnutella                  disabled - unmaintained
 - Gnutella2                 disabled - unmaintained
 - Direct Connect            disabled
 - Open Napster              disabled - currently not usable
 - Soulseek                  disabled - currently not usable
 - OpenFT                    disabled - currently not usable

Core features:
 - zlib (required)   enabled
 - threads           enabled
 - bzip2             enabled
 - iconv             enabled
 - libmagic          enabled
 - upnp & natpmp             disabled
 - graphical stats           disabled

Compilers:
 - OCaml version     4.01.0 - byte code
 - gcc version       11
 - g++ version       11

\nNow execute 'gmake' to start compiling. Good luck!

To compile a static code execute:     gmake mlnet.byte.static
To produce a release tarball execute: gmake release.mlnet.static
To clean the build directory execute: gmake maintainerclean

Compiling CryptoPP.cc can take several minutes, on slow machines up to half an hour.
/home/mhe/mldonkey/mldonkey/patches/local/bin/ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4  -c src/utils/lib/syslog.mli
/home/mhe/mldonkey/mldonkey/patches/local/bin/ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4  -c src/utils/cdk/printf2.mli
/home/mhe/mldonkey/mldonkey/patches/local/bin/ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4  -c src/utils/cdk/printexc2.mli
/home/mhe/mldonkey/mldonkey/patches/local/bin/ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4  -c src/utils/lib/verificationBitmap.mli
/home/mhe/mldonkey/mldonkey/patches/local/bin/ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4  -c src/utils/lib/intmap.mli
/home/mhe/mldonkey/mldonkey/patches/local/bin/ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4  -c src/utils/lib/options.mli
/home/mhe/mldonkey/mldonkey/patches/local/bin/ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4  -c src/utils/lib/url.mli
/home/mhe/mldonkey/mldonkey/patches/local/bin/ocamlc -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4  -c src/utils/cdk/zip.mli
File "src/utils/cdk/zip.mli", line 149, characters 32-37:
Error: Unbound type constructor bytes
make: *** [Makefile:5419: src/utils/cdk/zip.cmi] Error 2

https://github.com/ygrek/mldonkey/commits/master Unfortunately I am not proficient in OCaml to fix this problem. Could someone please have a look?

ygrek commented 4 months ago

ocaml 4.01.0 is not supported anymore latest master with at least 4.03.0 should fix this

Compiler11 commented 3 months ago

Yes, it did. Thanks!