search

ygrek / ocurl

OCaml bindings to libcurl
https://ygrek.org/p/ocurl
MIT License
59 stars 32 forks source link

Add activesocket API, return proper Unix.file_descr #42

Closed toots closed 3 years ago

toots commented 3 years ago

This PR adds the active socket API, which deprecates and replaces the last socket API: https://curl.se/libcurl/c/CURLINFO_ACTIVESOCKET.html

It also changes the return type to return proper Unix.file_descr.

I haven't included the autoconf/automake changes since I am not sure how you usually re-generates those.

toots commented 3 years ago

Sounds good. I've pushed what should be the final PR. I also fixed the omulti example & removed Libevent to avoid external dependencies so it can be built by default.

ygrek commented 3 years ago

I also fixed the omulti example & removed Libevent to avoid external dependencies so it can be built by default.

I appreciate the change but I cannot appreciate that it also includes the reformatting of the whole file so it is impossible to review the essential change

ygrek commented 3 years ago

actually thanks it is in separate commit

ygrek commented 3 years ago

Cherry-picked without omulti changes : bc339867711abcbe8b83f51cf27d254eab5616be Thanks!