ygrek / ocurl

OCaml bindings to libcurl
https://ygrek.org/p/ocurl
MIT License
59 stars 32 forks source link

Publish a version with dune support #66

Open gridbugs opened 1 year ago

gridbugs commented 1 year ago

Hi! I'd like to vendor ocurl in a project that builds with dune. I noticed that ocurl recently got dune support, but it hasn't been released since then. Can you please do a release that includes the dune support.

ygrek commented 1 year ago

unfortunately it seems there are new issues that need to be resolved first - lwt and lwt_ppx is marked as depopt but build actually fails when lwt_ppx is missing

nojb commented 1 year ago

@kit-ty-kate: can you assist on what is the standard way to layout packages which have parts with optional dependencies which should only be installed if the dependencies are present? Thanks!

kit-ty-kate commented 1 year ago

As a personal advice i would implore people to avoid optional subpackages as they're simply more annoying for users, lint/build tools makers and opam-repository maintainers alike.

That said, as for the issue at hand I'm not sure to see where lwt_ppx is actually used. I'm only seeing it in the examples directory where it is used to build an executable that isn't installed or tested using opam (it's only used when calling dune build with any arguments by hand). So the depopt towards lwt_ppx should just be removed and there shouldn't be any problem.

kit-ty-kate commented 1 year ago

I just noticed that you're using OCaml-CI. By deduction I'm guessing the "failure" mentioned above are from there.

OCaml-CI cannot be used for this repository anyway as it requires the out-of-the-box dune build to work and the current setup this repository has requires calling the ./configure script first to generate the required dune-project file for some reason.