Various fixes for Windows building with mingw32

dra27 commented 9 years ago

A few alterations in this branch for Windows building, originally against 0.7.2 but with some other changes:

Hard-coded requirement for .so changed to read ocamlc -config (I've done this in a way which implies GNU make being used - it might be better if configure derived $(SO)?)
Some minor git configuration changes when developing on Windows (.gitignore/.gitattributes)
Two changes made since 0.7.2 were breaking build - not clear if it was Windows-only. I couldn't make out exactly why it wasn't working, but the fact that TCP_NODELAY is 0x0001 seemed to be getting in the way of SETOPT_BOOL - solution was to revert the change for this version, but it's not entirely satisfactory. Additionally, test_memory_leaks.ml was using 4.02's pattern matching on exceptions, which prevents building under 4.01. I opted to eliminate the syntax, rather than altering configure to exclude the test for OCaml < 4.02.0

ygrek commented 9 years ago

Added workaround for TCP_NODELAY and cherry-picked other changes except Fix build process for mingw32

ygrek commented 9 years ago

@dra27 can you please check this patch on windows : https://gist.github.com/ygrek/e08356b73269367632b2

dra27 commented 9 years ago

Just trying the patch - how are these gist things supposed to work? I've downloaded the diff file, but all I get is:

C:\MetaStack\Projects\Working\ocurl>git apply gistfile1.diff
fatal: corrupt patch at line 93

Applying it by hand, but patch and anything else I'm trying seem to regard the diff as corrupt...

dra27 commented 9 years ago

Ah, actually I think the problem is the gistfile - you seem to have expanded the tabs to spaces! Anyway, I've tested that patch against 09f4c7a and it all seems to be working fine. Would it be OK to cut a release?

ygrek commented 9 years ago

Sorry for that and thanks for the patches and testing! I will do a release soon

ygrek / ocurl

Various fixes for Windows building with mingw32 #8