search

yhatt / marp

The site of classic Markdown presentation writer app
https://yhatt.github.io/marp/
MIT License
7.89k stars 398 forks source link

Emoji's not exported to PDF #57

Closed neilstuartcraig closed 5 years ago

neilstuartcraig commented 8 years ago

Hi all

I just started using Marp and it's excellent - it's replaced PPT already.

I noticed that emoji's aren't exported to PDF though (i tried viewing in preview and Chrome) on both my OSX 10.9 and 10.11 installs. I don't think there's a generic issue with emoji's and PDF as e.g. this PDF has emoji's.

Happy to help/test/code in any way necessary if you're interested in supporting this.

Cheers Neil

yhatt commented 8 years ago

I also saw it in OSX 10.11. Are you using Apple's emoji? (You'll see emoji image at text buffer if you use it)

We will look for how to resolve. Until we resolve this issue, you can use Github style syntax like :smile:.

neilstuartcraig commented 8 years ago

Ah cool, thanks. Yes, I was using Apple emojis which don't work for me. Changing to GH emojis does work in the preview and the exported PDF.

djds23 commented 7 years ago

@yhatt as a note, this does not work inside code snippets.

I use 👈 ☝️ 👇 in code comments for snippets in my slides, and the :point_up: syntax is rendered as text, not as the emoji.

Thank you very much for your work on this product!

yhatt commented 6 years ago

We're still keeping to work about emoji problems.

In the core of Marp Next, we support the aggressive conversion of emoji (shortcode and Unicode) into SVG vector images provided by twemoji. It can convert emoji in <code> element too. It would be a default behavior of Marp Next because we want to provide immutable exported result in any environments.

The trade-off for using aggressive conversion is not to be possible rendering Unicode emoji by system fonts (e.g. Apple Color Emoji, Segoe UI Emoji). So Marp Core can disable the agressive conversion, but it causes issues for each environments.