search

yhaugom / com.telldus

Homey support for Telldus Z-wave devices
5 stars 14 forks source link

Icon missing in app for Plug-in Switch Mini (TZWP-102) #18

Closed marcus-karlsson closed 5 years ago

marcus-karlsson commented 5 years ago

The icon is not visible for Plug-in Switch Mini (TSWP-102). Not in pairing GUI and not in buttons once paired. See attached screenshots. I do not know how to fix it.

IReplaced icon.svg (com.telldus\drivers\TZWP-102\assets\icon.svg) with the icon.svg for Schuko plug (com.telldus\drivers\TZWP-100\assets\icon.svg) then that icon is visible but it is of course the wrong icon.

Tried editing/creating new icon in incscape and re-save it. Then again there is no icon visible. Do the svg files need to be approved/signed by Athom or do you have to make them in specific editor?

marcus-karlsson commented 5 years ago

Forgot the screenshots....

screenshot_20190222-094134_homey

screenshot_20190222-093408_homey

yhaugom commented 5 years ago

I think this could have to do with the way the icon are made. I used an online free png to svg converter, and that made some blank space down and to the right of the part of the image I wanted. Didn't know how to fix this, so I raised an issue here Seems the viewport is the important part here, but there also seems to be general problems with icons atm: Icon issue

yhaugom commented 5 years ago

The icon seems fine in my opinion. Maybe just some Athom issues?? Icon for the TZWP-100 does seem small...

JohanBendz commented 5 years ago

There is an ongoing Athom issue about this, the icons are good.

marcus-karlsson commented 5 years ago

Yes the working icon could be slightly bigger. I guess than it is some Athom issue. I actually took the working icon (TZWP-100) edited it just by removing the two black dots which are the holes where the prongs would plugin. that icon did not work either. I wanted to test some more but now I cannot logon to my homey from CLI anymore, getting this: "str.replace is not a function" Once I figure that out I can continue playing with it...

marcus-karlsson commented 5 years ago

@yhaugom By trial and error I sized up the icon for TZWP-102 to something that works for me. Made a pull request for the new icon.svg I uploaded, check it out if you want to use it... This is what it look like for me now:

screenshot_20190306-223755_homey

marcus-karlsson commented 5 years ago

@yhaugom As the new icon has been merged I think this issue can be closed.

Thanks Marcus

marcus-karlsson commented 5 years ago

Closing it