search

yhilpisch / py4at

Jupyter Notebooks and code for the book Python for Algorithmic Trading (O'Reilly) by Yves Hilpisch.
http://home.tpq.io/books/py4at
Other
643 stars 325 forks source link

Python for Algorithm Trading - Chapter 5 - Page 158 - Typo #3

Open edgetrader opened 3 years ago

edgetrader commented 3 years ago

For recording purpose here

Code line 162

%%time
model.fit(training_data[cols], 
          training_data['direction'], 
          epochs=50, verbose=False, 
          validation_split=0.2, shuffle=False)

Should be to train model with normalised features

%%time
model.fit(training_data_[cols], 
          training_data['direction'], 
          epochs=50, verbose=False, 
          validation_split=0.2, shuffle=False)

Dr Yves' has replied here

BeneInfosec commented 1 year ago

For recording purpose here

Code line 162

%%time
model.fit(training_data[cols], 
          training_data['direction'], 
          epochs=50, verbose=False, 
          validation_split=0.2, shuffle=False)

Should be to train model with normalised features

%%time
model.fit(training_data_[cols], 
          training_data['direction'], 
          epochs=50, verbose=False, 
          validation_split=0.2, shuffle=False)

Dr Yves' has replied here

Yes, I think the same.