search

yhirose / cpp-peglib

A single file C++ header-only PEG (Parsing Expression Grammars) library
MIT License
880 stars 112 forks source link

Just a few small changes to silence warnings on VS2022 on Windows. #241

Closed rwtolbert closed 2 years ago

rwtolbert commented 2 years ago

Mostly just sprintf warnings although there was a weird one where an unnamed std::vector was created but not used in the case of a nullptr (c). I think this might have been an odd typo, since the next line would use "c" even if it was null.

yhirose commented 2 years ago

@rwtolbert, thanks for the feedback. As for the nullptr (c_) problem, I fixed it in a different way at eaef1725d7ce3b41b87752a1e50f9a99d2021688.

rwtolbert commented 2 years ago

thanks. If I make a new pull request with the other changes, is that worth the effort?

yhirose commented 2 years ago

Yes, please!