search

yhirose / cpp-peglib

A single file C++ header-only PEG (Parsing Expression Grammars) library
MIT License
916 stars 113 forks source link

`BUILD_TESTS` vs. `PEGLIB_BUILD_TESTS` #251

Closed russkel closed 2 years ago

russkel commented 2 years ago

Hello,

Is there a reason to use this over the standard BUILD_TESTS? Other tooling will have to handle this case explicitly.

https://github.com/yhirose/cpp-peglib/blob/dde4aaeb2fd7043f1548cee7e4f1bffdd2001a53/CMakeLists.txt#L13

yhirose commented 2 years ago

@NotAPenguin0, could you explain it to @russkel since it came from your contribution. Thanks!

yhirose commented 2 years ago

@russkel, can I simply rename PEGLIB_BUILD_TESTS to BUILD_TESTS? If so, I'll do it right away. :)

russkel commented 2 years ago

Yep that'll do it :).

yhirose commented 2 years ago

Thanks!

russkel commented 2 years ago

Thanks for fixing this @yhirose !