yhirose / cpp-peglib

A single file C++ header-only PEG (Parsing Expression Grammars) library
MIT License
879 stars 112 forks source link

Issues when installing CMake project #252

Closed russkel closed 1 year ago

russkel commented 1 year ago

Hello,

When Cmake building and installing this project it looks like there's a few issues:

Other header only libs like argparse and canary install a cmake file and their includes upon build/install of the cmake project. Perhaps this is a good standard to follow?

Files installed:

./
./usr/
./usr/include/
./usr/include/gmock/
./usr/include/gmock/gmock-actions.h
./usr/include/gmock/gmock-cardinalities.h
./usr/include/gmock/gmock-function-mocker.h
./usr/include/gmock/gmock-matchers.h
./usr/include/gmock/gmock-more-actions.h
./usr/include/gmock/gmock-more-matchers.h
./usr/include/gmock/gmock-nice-strict.h
./usr/include/gmock/gmock-spec-builders.h
./usr/include/gmock/gmock.h
./usr/include/gmock/internal/
./usr/include/gmock/internal/custom/
./usr/include/gmock/internal/custom/README.md
./usr/include/gmock/internal/custom/gmock-generated-actions.h
./usr/include/gmock/internal/custom/gmock-matchers.h
./usr/include/gmock/internal/custom/gmock-port.h
./usr/include/gmock/internal/gmock-internal-utils.h
./usr/include/gmock/internal/gmock-port.h
./usr/include/gmock/internal/gmock-pp.h
./usr/include/gtest/
./usr/include/gtest/gtest-death-test.h
./usr/include/gtest/gtest-matchers.h
./usr/include/gtest/gtest-message.h
./usr/include/gtest/gtest-param-test.h
./usr/include/gtest/gtest-printers.h
./usr/include/gtest/gtest-spi.h
./usr/include/gtest/gtest-test-part.h
./usr/include/gtest/gtest-typed-test.h
./usr/include/gtest/gtest.h
./usr/include/gtest/gtest_pred_impl.h
./usr/include/gtest/gtest_prod.h
./usr/include/gtest/internal/
./usr/include/gtest/internal/custom/
./usr/include/gtest/internal/custom/README.md
./usr/include/gtest/internal/custom/gtest-port.h
./usr/include/gtest/internal/custom/gtest-printers.h
./usr/include/gtest/internal/custom/gtest.h
./usr/include/gtest/internal/gtest-death-test-internal.h
./usr/include/gtest/internal/gtest-filepath.h
./usr/include/gtest/internal/gtest-internal.h
./usr/include/gtest/internal/gtest-param-util.h
./usr/include/gtest/internal/gtest-port-arch.h
./usr/include/gtest/internal/gtest-port.h
./usr/include/gtest/internal/gtest-string.h
./usr/include/gtest/internal/gtest-type-util.h
./usr/include/peglib.h
./usr/lib/
./usr/lib/x86_64-linux-gnu/
./usr/lib/x86_64-linux-gnu/cmake/
./usr/lib/x86_64-linux-gnu/cmake/GTest/
./usr/lib/x86_64-linux-gnu/cmake/GTest/GTestConfig.cmake
./usr/lib/x86_64-linux-gnu/cmake/GTest/GTestConfigVersion.cmake
./usr/lib/x86_64-linux-gnu/cmake/GTest/GTestTargets-none.cmake
./usr/lib/x86_64-linux-gnu/cmake/GTest/GTestTargets.cmake
./usr/lib/x86_64-linux-gnu/libgmock.a
./usr/lib/x86_64-linux-gnu/libgmock_main.a
./usr/lib/x86_64-linux-gnu/libgtest.a
./usr/lib/x86_64-linux-gnu/libgtest_main.a
./usr/lib/x86_64-linux-gnu/pkgconfig/
./usr/lib/x86_64-linux-gnu/pkgconfig/gmock.pc
./usr/lib/x86_64-linux-gnu/pkgconfig/gmock_main.pc
./usr/lib/x86_64-linux-gnu/pkgconfig/gtest.pc
./usr/lib/x86_64-linux-gnu/pkgconfig/gtest_main.pc
./usr/share/
./usr/share/doc/
./usr/share/doc/cpp-peglib/
./usr/share/doc/cpp-peglib/changelog.Debian.gz
./usr/share/doc/cpp-peglib/copyright
yhirose commented 1 year ago

@russkel, thanks for your feedback. Honestly, I am not an expert of CMake. I simply started with a simple CMakeLists.txt just for building unit tests and peglint. I have accepted contributions from others since then, but I basically don't know much of the changes. :)

I'll close it for now since I am not planing to work on it. Pull requests are always welcome to improve the CMake support for cpp-peglib. Thank you!

russkel commented 1 year ago

Understood, working with cmake is an absolute pain. Unfortunately cpp-peglib is only a nested dependency of one of the projects I am working on. They have hacked in peglib with a http download and I don't have the time to fix that at this point.