Avoid redundant string allocations in trie match

yhirose / cpp-peglib

A single file C++ header-only PEG (Parsing Expression Grammars) library

MIT License

916 stars 113 forks source link

Avoid redundant string allocations in trie match #295

Closed joankaradimov closed 8 months ago

joankaradimov commented 8 months ago

This is attempt to fix #294...

move a string allocation outside a while loop
avoid creating extra string instances when not ignoring case

P.S. This improves the performance regression situation, but it doesn't solve it. It's probably better to reject this PR and implement an alternative solution.

yhirose commented 8 months ago

@joankaradimov thanks for the pull request! It helped me to understand how to fix it. You can see my fix at f61052359c1a0e621b69a54ab5c8b938c2e757df.