yhtang / FunFact

Tensor decomposition with arbitrary expressions: inner, outer, elementwise operators; nonlinear transformations; and more.
Other
56 stars 4 forks source link

Factorization object only return unique factors. Fixes #210. #213

Closed yhtang closed 2 years ago

yhtang commented 2 years ago

This PR also involves the following changes as by-products in order to address bug #210:

campsd commented 2 years ago

Looks good. I like the secret key 😄

One thing that I noticed, append was replaced by vec_axis in some but not all places. Any particular reason for having two different names?

yhtang commented 2 years ago

One thing that I noticed, append was replaced by vec_axis in some but not all places. Any particular reason for having two different names?

Well, it was when I was using it that I realize the append argument, without a proper context, may seem unintuitive for users. Hence, I renamed the user-facing arguments to vec_axis, but kept all internal usage as append. What do you think?

yhtang commented 2 years ago

Also, together with renaming nvec to vec_size, we unify the two related arguments so that they look more like a group: nvec -> vec_size append -> vec_axis

campsd commented 2 years ago

Makes sense!