yhtang / GraphDot

GPU-accelerated Marginalized Graph Kernel with customizable node and edge features; Gaussian process regression.
https://graphdot.readthedocs.io
Other
19 stars 2 forks source link

[bug report] a minor logging bug in graphdot/kernel/marginalized/_kernel.py #1

Closed henryliuw closed 4 years ago

henryliuw commented 4 years ago

It's a super minor bug so I think I may just report its instead of following the bug report

On the definition of diag function in kernel on this line, a timer is set as function argument to turn timer on/off. Then on the begining line of this function, a timer is initialized regardless of the function argument, which, turn out to log unwanted information later in the logging part

We changed it in our local src code to avoid redundant logging and maybe a change in original code would be better

yhtang commented 4 years ago

Thanks for reporting! I fixed it in 72f369a295e0a40c3576dd81154e448303836cf7.