search

yibn2008 / fast-sass-loader

High performance sass loader for webpack
250 stars 38 forks source link

Add Webpack 4 support #30

Closed hugmanrique closed 6 years ago

hugmanrique commented 6 years ago

Previously, we were using context.options, which was deprecated in Webpack 3 and removed in Webpack 4 (https://medium.com/webpack/webpack-4-migration-guide-for-plugins-loaders-20a79b927202).

This shouldn't break any previous versions because we still use loader-utils to get the options.

Fixes #28

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.09%) to 85.366% when pulling fd010a39b48dcf4d00a74f1dad3edd4c494d96e2 on hugmanrique:master into 8a37b5545565fcb828befd5b786e907ad7e564e7 on yibn2008:master.

AviVahl commented 6 years ago

Final webpack 4 release is out. @yibn2008, could you check this PR out?