Project Feedback

[yichuandoris]

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] At every URL, you respond with HTML, starting with an h1 element (though for this project, it doesn't have to be a complete HTML page)
• [x] When a user visits /, they see a greeting
• [x] When a user visits /random-joke, they see one of at least three knock-knock jokes (Math.random() may be useful 😉)
• [x] When a user visits /cuteness, they see a picture of a cute animal (I'm sure you can find one on the Internet 😛)
• [x] At every other URL, display an error page (if you want to make it funny, see these examples for inspiration)
• [x] The error page includes the requested URL, similar to Google's error page
• [x] Every page that is not the homepage (/) contains a link to it

[egillespie]

Outstanding work, @yichuandoris! Your site works great and the code looks good too.

I have one recommendation to help make your code easier to read. If one line of code is so long that you have to scroll to read the whole line, it's okay to write the code on multiple lines.

For example, this line of code:

response.end('<a href="/">Home</a>' + '<h1>404 Error. Page Not Found!</h1>' + 'The requested URL ' + '<strong>' + request.url + '</strong>' + ' was not found on this server.' + '<p>That’s all we know.</p>')

Could be written in multiple lines by moving each string onto its own line, like this:

response.end(
  '<a href="/">Home</a>'
  + '<h1>404 Error. Page Not Found!</h1>'
  + 'The requested URL <strong>'
  + request.url
  + '</strong> was not found on this server.'
  + '<p>That’s all we know.</p>'
)

Try updating all of your long lines of code like this, then push them to GitHub and I'll take another look.

Thanks! 🦉

[yichuandoris]

Hi Erik, Thanks for the recommendation. I've updated those long lines and git push to GitHub as well as Heroku. Kindly have another look. Thank you. - Doris

[egillespie]

Looks good! Thanks for touching that up. :shipit: