yichya / luci-app-xray

(Almost) full feature Xray client for OpenWrt
Mozilla Public License 2.0
580 stars 433 forks source link

Is there a bug in Official Docs https://github.com/yichya/luci-app-xray#installation ? #293

Closed yukeiyang closed 1 year ago

yukeiyang commented 1 year ago

The Official Docs about Installation Choose one below: Add src-git-full luci-app-xray https://github.com/yichya/luci-app-xray to feeds.conf.default
and run ./scripts/feeds update -a; ./scripts/feeds install -a

There is one error displayed when run ./scripts/feeds update -a; $ cd openwrt-sdk-*Linux-x86_64 && sudo vi feeds.conf.default
src-git-full luci-app-xray https://github.com/yichya/luci-app-xray

then, an error displayed. Syntax error in feeds.conf.default, line 6

Seems the format of "src-git-full luci-app-xray" is not right. if change it to: "src-git-full luci_app_xray", it works fine. But I don't know whether it will cause some other errors in the next steps for compiling ipk files or not.

plus, there is one issue displayed when make ipk. $ make package/luci-app-xray/compile -j1 V=s make[1]: Entering directory '/home/plus/openwrt-sdk-22.03.4-x86-64_gcc-11.2.0_musl.Linux-x86_64' make[1]: *** No rule to make target 'package/luci-app-xray/compile'. Stop.

The previous version works fine, it happened only in this new version of luci-app-xray.

yichya commented 1 year ago

Seems the format of "src-git-full luci-app-xray" is not right. if change it to: "src-git-full luci_app_xray", it works. But I don't know whether it will cause some error in the next steps for compiling ipk files or not.

I don't think that matters but I'll try that.

plus, there is one issue displayed when make ipk. $ make package/luci-app-xray/compile -j1 V=s make[1]: Entering directory '/home/plus/openwrt-sdk-22.03.4-x86-64_gcc-11.2.0_musl.Linux-x86_64' make[1]: *** No rule to make target 'package/luci-app-xray/compile'. Stop.

You have to specify variant (for example make package/luci-app-xray/fw4/compile).

yukeiyang commented 1 year ago
  1. Official Installation should adjust src-git-full luci-app-xray https://github.com/yichya/luci-app-xray to src-git-full luci_app_xray https://github.com/yichya/luci-app-xray

  2. Yes, you right. should be: $ make package/luci-app-xray/fw4/compile

It works fine. thank you.

yichya commented 1 year ago

Updated README.