search

yidie / STAT545-hw-Feng-Yidie

0 stars 0 forks source link

hw01 ready for grading #1

Open yidie opened 6 years ago

yidie commented 6 years ago

@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho

rainerlempert commented 6 years ago

Yidie,

Nice job on hw01! I enjoyed learning a little bit about you and your goals for the course. A couple of specific comments:

README I noticed that you experimented with a few different aspects of Markdown syntax, including embedded links, headings, lists, and embedded pictures. Did you need to include the ouput header at the top of your readme? Your report process was thorough. What do you mean by following correct workflow? Are you referring to the pull - commit - push sequence?

Gapminder exploration You played around with plotting data on gapminder, and you including the markdown file. Seems good to me!

hsmohammed commented 6 years ago

Hello,

I have explored your homework01 repo and I just have some comments 1- Good job in trying out different markdown formats. 2- I would have been better if you made a hyperlink to the gapminder data in the main readme file. 3- I see you did explore a lot of the tibble functionality using the tidyverse library, and using visualization too.

Thank you, Hossameldin Mohammed

yidie commented 6 years ago

@rainerlempert Thanks for your review. I have deleted the output header on the top of my readme. By correct workflow, yes, I mean commit-pull-push sequence.

@hsmohammed Thanks for your review. Good suggestion. I have linked hw01 in the main readme.

JoeyBernhardt commented 6 years ago

Correctly named issue: Yes Link to work to be reviewed: In README Use 4 or more aspects of markdown: Yes (headings, list, formatting, code style) Reflections / how it was done: Yes Gapminder exploration: Yes

Comments:

Very nicely done! Nice use of images, links and lists! Reflections on the process could be a little more detailed next time. Gapminder exploration was good, although next time, I recommend adding a little narrative about the figures are saying -- is there anything surprising in there? What story do they tell?

Note: your mark will be sent out later.