yidie / STAT545-hw-Feng-Yidie

0 stars 0 forks source link

hw10 ready for grading #10

Open yidie opened 6 years ago

margotgunning commented 6 years ago

Hi @yidie,

Your README was good, and your progress report was good/concise in addressing issues and what you did to solve them. I agree that scraping can be a useful tool, and that character data is annoying to deal with.

Your summary report was easy to follow, and your commentary was clear and concise, as was your hashed code. My workflow looked very similar in that I also created a dataframe using similar piping/ideas; however, I totally forgot to save my cleaned dataframe, so I'm glad I saw that you did that, and I'll be adding it into my work.

I think you did a good job doing exploratory analysis with your character dataframe. I liked how you did a 'sanity' check with the number of actors/actresses, and that they all had a 'voice' tag attached to them. You also made a good for loop for extracting the number of films for each actor/actress, and had some good comments.

Overall, well done!

Happy Holidays,

Margot

zxkathy commented 6 years ago

Hi @yidie,

This is Kathy and I am happy to review your HW10. Below are my comments:

Happy Holidays,

Kathy

derekcho commented 6 years ago

Hi @yidie, here are some comments about your hw10:

Task(s) selected: Scrape data Data stored as file ready for downstream analysis: Yes Basic Exploration: Yes Reflection: Yes

Your grade will be emailed to you at a later date.