Open yidie opened 6 years ago
Hi @yidie,
This is Kathy and I am happy to review your HW10. Below are my comments:
You did the task of scrap the data and have successfully extract a nice data frame from the website. I can see you understand how to use functions such as html_nodes
, html_text
, collapse
, and read_html
. You can also locate to the correct nodes to find the required information as well.
You also tried to do some exploratory analysis. As your data frame consists only characters, so your exploratory analysis is a bit interesting to me. You firstly checked whether the Filmography
contains Coco
, and whether Voice
was contained in Role
column. Then, you checked how many films have the actor/actress played.
You have really clear workflow overall. In addition, your README file is impressively clear to me. You have summarized the problems you encountered and corresponding solutions. This would be really helpful to me especially after I went through your help resources.
Happy Holidays,
Kathy
Hi @yidie, here are some comments about your hw10:
Task(s) selected: Scrape data Data stored as file ready for downstream analysis: Yes Basic Exploration: Yes Reflection: Yes
Your grade will be emailed to you at a later date.
Hi @yidie,
Your README was good, and your progress report was good/concise in addressing issues and what you did to solve them. I agree that scraping can be a useful tool, and that character data is annoying to deal with.
Your summary report was easy to follow, and your commentary was clear and concise, as was your hashed code. My workflow looked very similar in that I also created a dataframe using similar piping/ideas; however, I totally forgot to save my cleaned dataframe, so I'm glad I saw that you did that, and I'll be adding it into my work.
I think you did a good job doing exploratory analysis with your character dataframe. I liked how you did a 'sanity' check with the number of actors/actresses, and that they all had a 'voice' tag attached to them. You also made a good for loop for extracting the number of films for each actor/actress, and had some good comments.
Overall, well done!
Happy Holidays,
Margot