hw09 ready for grading

[yidie]

My package is in a different repo. You can find it here.

Process Report:

• Jenny's tutorial is very helpful. It is very cool that now I know how to build an R package from scratch.

• I encountered some issue when writing fbarplot() function. I make use of ggplot in this function., which gives me a note message "no visible binding for global variable" when I run check. I searched online and found this post, which resolves my issue. After I changed ggplot2::aes(x=x,y=n) to ggplot2::aes_(x=~x,y=~n), it works. This might be helpful if you, by any chance, need to use ggplot for your package in the future and run into the same problem.

• At first, I am not sure how to write tests for fbarplot() function because it returns a plot. This post is very helpful. However, a package called proto is used in order to access sub-components of ggplot2 object. I have added this package to imports section in DESCRIPTION. And I called library(proto) in test_fbarplot.R because I am not sure how to use something like proto:: in this case since I am not really using any function from that package.

[menglinzhou]

Hi! @yidie I am really happy to review your homework, and I think you did a great job! I installed your package, and it works well.

• Your readme.md file is easy to read and the examples are easy to follow. You created two new functions: one is to detect factors that should be character and another one is to plot the categorical data. That’s great and useful!
• In your function, you also use the stopifont to check the user’s input, that makes your function more robust. Also, in your testthat.R file, it’s really nice that you wrote three different types of unit tests for each functions: expect_false, expect_true, expect_error. So, I think you have achieved most of the requirements of the homework. Besides, there are also some things I think you need to improve.
• I find your namespace file don’t include your exported functions. Do you use document() to mange your NAMESPACE file? And in your readme.md file, I will suggest you to add more explanations to your examples which will let the user to understand your functions more easily.

Overall, I think you did a really nice job in this homework and I am looking forward to see more features added to your package!

Menglin Zhou

[cheungamanda]

Hi @yidie , Great work! Here's my review for homework 09:

Coding style: Clear and organized, easy to follow along! I would suggest adding comments to explain your code

Coding strategy: Simple and efficient, logical flow of code

Presentation - graphs: Great job with fbarplot() and incorporating various ggplot2 features

Achievement, mastery, cleverness, creativity: Excellent application of tools and techniques learned from the course and beyond. Great job completing the chosen tasks thoroughly! I like that you chose a different package from what was done in class and challenged yourself

Ease of access for instructor, compliance with course conventions for submitted work: + Easy access, code runs!

• Your NAMESPACE is missing your functions!

• Your README file is detailed and contains a good amount of examples. You wrote different types of unit tests which was great to see!

• Overall great work! 👍

Thanks, Amanda

[derekcho]

Hi @yidie, here are some comments about your hw09:

Able to install properly: Yes At least one new function: Yes Used assertions to check function input: Yes Documented exported functions: Yes Includes three unit tests for each function: Yes Passes check: Yes README and vignette: Yes Reflections included: Yes

• I was able to download and install your package without any problems
• You included assertions in your functions to check for erroneous input, although it seems strange that you used stopifnot() in one function but an if/else with stop in the other. You should try to stick with if/else with stop when possible
• Rather than printing TRUE or FALSE, you should have the function fdetect return these values. That way if you use fdetect in other parts of the code, it will not print every time you call this function. Both methods will still return TRUE or FALSE and if you only run this function like in your example, they will both print TRUE or FALSE too
• Your README file was good and it provided lots of details on how to use your package. I would suggest switching the level of detail between the vignette and README since the package vignette should contain more details on how to use the package
• Individual functions are well documented with examples of how to properly use the function
• Unit testing for your functions was well done
• Good work overall, your package runs smoothly and was done well!

Your grade will be emailed to you at a later date.