Liquidity functions - Githubissues

yieldprotocol / yieldspace-tv

Yield Protocol: Yieldspace AMM for fyTokens and tokenized vault tokens

Other

46 stars 4 forks source link

Liquidity functions #47

Closed ultrasecreth closed 2 years ago

ultrasecreth commented 2 years ago

Small test improvements
Implement maxFYTokenIn
WIP maxFYTokenOut
maxFYTokenOut working
maxSharesIn working
liquidity methods added to the Pool
Add tests for liquidity methods at the pool level, fix bug on sellFYTokenPreview

devtooligan commented 2 years ago

Let's remember to lint this right before it gets merged. I don't wanna lint it now because i'm afraid changes will get lost in the diff

ultrasecreth commented 2 years ago

Let's remember to lint this right before it gets merged. I don't wanna lint it now because i'm afraid changes will get lost in the diff

yeah, I think I mentioned this somewhere I think, the linter in VSCode was changing so many things I decided not to, so the PR was clean. I think there should be a different PR where not only the whole project is linted but also to commit the shared linting conf for the plugin and the .vscode to use it so everything is consistent in both IDE & command line for all devs

ultrasecreth commented 2 years ago

Approving, but I'd still like to have a discussion around the methodology used with the "regular" pow function and explore whether:

a) It is appropriate to use that methodology in all edge cases b) It can be used for the third max function

Should we schedule a zoom call?