search

yifanlu / taiHEN

CFW framework for PS Vita
MIT License
310 stars 46 forks source link

Support for a *GAME section #78

Open chaoskagami opened 7 years ago

chaoskagami commented 7 years ago

*ALL is nice, but behaviour often differs from what is expected. Badly coded plugins tend to crash homebrew and system applications, but some are useful even so.

Another token which only applies plugins to "games" -- as in, titles starting in PCSA, PCSE, PCSB, PCSG, etc but not PCSX/NPXS -- would be desirable. It would ease configuration, and shorten my config file by at least 50 lines.

Obviously if someone were to use a stupid titleID for a homebrew, it would cause issues, but nobody has done so yet as far as I am aware.

CelesteBlue-dev commented 7 years ago

I agree. I had this idea too.

yifanlu commented 7 years ago

It's a great idea like I said back in June, there won't be any new Vita stuff coming from me. The most you'll see are bug fixes.

chaoskagami commented 7 years ago

Are you against any new features in general due to maintenance burden, or are PRs acceptable for features? I completely understand either way.

To implement this, I'd need to add code to handle parsing it. I think most of the work would actually occur in taihen-parser, not here...perhaps I should have made the feature request there? I'm not against doing this myself, to be honest. It doesn't seem TOO complex.

chaoskagami commented 7 years ago

So, I went ahead and implemented it.

The above PR is probably the final iteration, unless I missed anything. I rebased a few times after opening that PR to optimize / fix stuff.

Compiling taiHEN with those changes in taihen-parser adds the functionality needed to support a GAME section.

CelesteBlue-dev commented 7 years ago

It seams good.