search

yifeikong / curl-impersonate

An active fork of curl-impersonate with more versions and build targets.
MIT License
52 stars 11 forks source link

Recheck boringssl's `OPENSSL_NO_ASM` for Windows build #12

Closed yifeikong closed 3 months ago

yifeikong commented 7 months ago

BoringSSL won't link without this option on Windows, due to missing symbols of the fiat lib.

This option literally means no assembly code at all, but the code says otherwise, it is not clear whether it turns off assembly completely or not. If so, performance can be hurt, if not, maybe we can leave it as is.

Useful links:

  1. https://github.com/grpc/grpc/issues/9440
  2. https://github.com/mit-plv/fiat-crypto
  3. https://boringssl.googlesource.com/boringssl/+/HEAD/BUILDING.md
  4. https://stackoverflow.com/questions/26963740/linking-in-assembly-files-with-mingw
  5. https://github.com/google/boringssl/blob/master/util/generate_build_files.py
  6. https://github.com/mxschmitt/action-tmate/issues/86