search

yihengsun / TransBoost

TransBoost algorithm for transfer learning
Apache License 2.0
31 stars 2 forks source link

Does monotone_constraint in xgboost work for transboost? #2

Open flippercy opened 2 years ago

flippercy commented 2 years ago

Hi @yihengsun:

Does monotone_constraint inherited from xgboost work for transboost? I checked the codes and it seemed so; however, when adding monotone constraints to the sample codes on the wine data, I always got the same model performance no matter what type of constraints I applied arbitrarily.

Any idea why?

Thank you.

yihengsun commented 2 years ago

Hi @flippercy , In transboost, we implemented the overall objective function and its estimation manually. Therefore, I'm afraid monotone_constraint won't work as expected. But that's a good recommendation for the future update. Thank you.

flippercy commented 2 years ago

Got it. Please let me know if you can add this feature in the future since it is critical for models used by industries with domain knowledge.

Thank you.

yihengsun commented 2 years ago

No problem. Thanks for the recommendation :)