yihong0618 / bilingual_book_maker

Make bilingual epub books Using AI translate
MIT License
7.33k stars 1.05k forks source link

gemini issue #377

Open likangkao opened 8 months ago

likangkao commented 8 months ago

Thank you for the fix. The translated srt file from gemini has correct content in it now. However, the first line in the translated srt file is always empty. Please check it. thank you! Here is the example: Original srt file: 1 00:00:05,650 --> 00:00:09,450 小時候請人算過命的人

2 00:00:09,450 --> 00:00:11,650 你在長大的過程之中

3 00:00:11,650 --> 00:00:13,370 你是不是也在印證著

Transltaed srt file: 1 00:00:05,650 --> 00:00:09,450

2 00:00:09,450 --> 00:00:11,650 During the process of growing up

3 00:00:11,650 --> 00:00:13,370 Are you also verifying that

yihong0618 commented 8 months ago

sorry what is your command can you share it ?

likangkao commented 8 months ago

python make_book.py --book_name D:\SRT\test.srt --gemini_key xxx --model gemini --language en --prompt prompt_template_sample.txt --single_translate

However, the gemini key in this command has been changed by me, so you can't use it directly. Please use your own gemini key.

On Sat, Jan 27, 2024 at 10:55 PM yihong @.***> wrote:

sorry what is your command can you share it ?

— Reply to this email directly, view it on GitHub https://github.com/yihong0618/bilingual_book_maker/issues/377#issuecomment-1913477805, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASEQGPGNQVL2UG2BL2HM6XLYQXY5PAVCNFSM6AAAAABCN3SN2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGQ3TOOBQGU . You are receiving this because you authored the thread.Message ID: @.***>

yihong0618 commented 8 months ago

so you use single_translate..I will check that, can you use it without --single_translate?

likangkao commented 8 months ago

Here is without --single_tanslate, the English translated part in line 1 is still missing. 1 00:00:05,650 --> 00:00:09,450 小時候請人算過命的人

2 00:00:09,450 --> 00:00:11,650 你在長大的過程之中 During your growing up process

3 00:00:11,650 --> 00:00:13,370 你是不是也在印證著 Are you also verifying

On Sun, Jan 28, 2024 at 1:03 AM yihong @.***> wrote:

so you use single_translate..I will check that, can you use it without --single_translate?

— Reply to this email directly, view it on GitHub https://github.com/yihong0618/bilingual_book_maker/issues/377#issuecomment-1913522963, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASEQGPAXXXYBZ27O7UU36C3YQYH6RAVCNFSM6AAAAABCN3SN2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGUZDEOJWGM . You are receiving this because you authored the thread.Message ID: @.***>

likangkao commented 8 months ago

Hi,

I live in the USA, and it is too late for me. I have to sleep now.

On Sun, Jan 28, 2024 at 1:18 AM LIKANG KAO @.***> wrote:

Here is without --single_tanslate, the English translated part in line 1 is still missing. 1 00:00:05,650 --> 00:00:09,450 小時候請人算過命的人

2 00:00:09,450 --> 00:00:11,650 你在長大的過程之中 During your growing up process

3 00:00:11,650 --> 00:00:13,370 你是不是也在印證著 Are you also verifying

On Sun, Jan 28, 2024 at 1:03 AM yihong @.***> wrote:

so you use single_translate..I will check that, can you use it without --single_translate?

— Reply to this email directly, view it on GitHub https://github.com/yihong0618/bilingual_book_maker/issues/377#issuecomment-1913522963, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASEQGPAXXXYBZ27O7UU36C3YQYH6RAVCNFSM6AAAAABCN3SN2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGUZDEOJWGM . You are receiving this because you authored the thread.Message ID: @.***>

likangkao commented 8 months ago

Here is my testing srt file. You can use it to test.

On Sun, Jan 28, 2024 at 1:35 AM LIKANG KAO @.***> wrote:

Hi,

I live in the USA, and it is too late for me. I have to sleep now.

On Sun, Jan 28, 2024 at 1:18 AM LIKANG KAO @.***> wrote:

Here is without --single_tanslate, the English translated part in line 1 is still missing. 1 00:00:05,650 --> 00:00:09,450 小時候請人算過命的人

2 00:00:09,450 --> 00:00:11,650 你在長大的過程之中 During your growing up process

3 00:00:11,650 --> 00:00:13,370 你是不是也在印證著 Are you also verifying

On Sun, Jan 28, 2024 at 1:03 AM yihong @.***> wrote:

so you use single_translate..I will check that, can you use it without --single_translate?

— Reply to this email directly, view it on GitHub https://github.com/yihong0618/bilingual_book_maker/issues/377#issuecomment-1913522963, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASEQGPAXXXYBZ27O7UU36C3YQYH6RAVCNFSM6AAAAABCN3SN2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGUZDEOJWGM . You are receiving this because you authored the thread.Message ID: @.***>

yihong0618 commented 8 months ago

ok will take a look thanks