Closed TimelyToga closed 3 months ago
nice and clean code, thanks very much. will check tonight (utc+8)
I just noticed there are some issues with unnecessary whitespace changes in README
. Let me fix that.
very nice solution and did not make any break change,
I think with your solution we had support openai like
api like grog or others.
@yihong0618 wow that's cool! Didn't even realize you had that feature. Thanks for the merge.
Can someone upload an example of using with Groq and Llama3? I would be thankful.
Can someone upload an example of using with Groq and Llama3? I would be thankful.
OK
This is in response to https://github.com/yihong0618/bilingual_book_maker/issues/390.
Solution
Currently this
openai
model alias is only for this behavior, but I think it should be expanded to be the defacto way to use the OpenAI API. The current approach is a bit messy becausechatgptapi
andgpt-4
are two separate top-level models.I opted to add a new
model
to preserve backwards compatibility, but also paves a path for future CLI improvements.Edge cases
No
--model_list
withopenai
:First model is not valid
We should probably include some automatic checking to make sure all the models you specify are valid, but since we're using
cycle()
, this failure should be found within the firstN
paragraphs.