yihong0618 / running_page

Make your own running home page
https://running-page.vercel.app
MIT License
3.41k stars 978 forks source link

设置`IGNORE_BEFORE_SAVING=1`后`gen_svg.py`报错 #558

Closed conanyangqun closed 7 months ago

conanyangqun commented 7 months ago

看了下代码,应该是 run_page/gpxtrackposter/track.pyload_from_db函数的问题。blame下,是在这个commit引入的。

未设置该环境变量时,不会触发bug。设置该变量,则导致summary_polyline发生未定义先引用错误。

按照我的理解,代码应该改成这个样子:

if IGNORE_BEFORE_SAVING:
        summary_polyline = filter_out(activity.summary_polyline)
else:
        summary_polyline = activity.summary_polyline
yihong0618 commented 7 months ago

@conanyangqun 感谢,能提个 PR 么把你的修改?

conanyangqun commented 7 months ago

@conanyangqun 感谢,能提个 PR 么把你的修改?

一会提一个,专门做个分支。稍后哦。

yihong0618 commented 7 months ago

谢谢

conanyangqun commented 7 months ago

谢谢

客气了。很有趣的项目,我不懂前端,对python有了解。感谢付出!我关这个issue了。