yihong0618 / running_page

Make your own running home page
https://running-page.vercel.app
MIT License
3.41k stars 978 forks source link

support google analytics page view tracking #572

Closed XmchxUp closed 6 months ago

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 7:39am
yihong0618 commented 6 months ago

This need to discuss, should we add this to user or just an options to tell user how to add google analytics @ben-29 @shaonianche @frostming @zhaohongxuan @vlin what do you think~?

zhaohongxuan commented 6 months ago

Since google analytics is not core part of the project, I think it's better to add toggle for users to decide whether to enable it or not , and it should be disabled by default, considering someone doesn't own a google analytics account, a forced google analytics configuration may be confused.

vlin commented 6 months ago

Since google analytics is not core part of the project, I think it's better to add toggle for users to decide whether to enable it or not , and it should be disabled by default, considering someone doesn't own a google analytics account, a forced google analytics configuration may be confused.

Fully agree.

XmchxUp commented 6 months ago

Sorry, I didn't consider that. I'll make the necessary changes.

XmchxUp commented 6 months ago

OK, I have made the required modifications. Thank you for your guidance. Is there anything else I can do to improve it further?

yihong0618 commented 6 months ago

kind of OK, will test and wait other reviewers later.

yihong0618 commented 6 months ago

@XmchxUp Thanks