search

yihong0618 / running_page

Make your own running home page
https://running-page.vercel.app
MIT License
3.55k stars 1.02k forks source link

fix: #584 change fit-tool to garmin-fit-sdk #590

Closed ben-29 closed 9 months ago

ben-29 commented 9 months ago

using Garmin official sdk to read fit file, fixing #584

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
running-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 11:07am
ben-29 commented 9 months ago

Should we add activities without .fit into the running page? For example, some activities manually uploaded with gpx.

I understand. When downloading the .fit file from Garmin, it returns a zip file containing the GPX if there is no .fit file available. Since it already downloads the GPX, I believe it's better to import it. I'll modify the code to handle this.

ben-29 commented 9 months ago

@NaturezzZ Could you help me verify if the issue has been resolved?

ben-29 commented 9 months ago

@NaturezzZ I brought the fit-tool back because the Garmin SDK doesn't offer the "encode to fit" function. Otherwise, "wrap_device_info" wouldn't work for Strava. Could you please take a look? Thanks

@yihong0618 Changed.

NaturezzZ commented 9 months ago

okay👌 it looks good to me

yihong0618 commented 9 months ago

Nice work thanks @ben-29 @NaturezzZ