feat: integrate gen_svg into joyrun_sync.py(#675)

yihong0618 / running_page

Make your own running home page

https://running-page.vercel.app

MIT License

3.4k stars 977 forks source link

feat: integrate gen_svg into joyrun_sync.py(#675) #680

Closed wayichao closed 1 week ago

wayichao commented 2 weeks ago

To resolve #675

By subprocess.run to serial start process.

Tried to investigate integrate gen_syg as module, but sys.argv must be updated before invoking gen_svg.main(). Repeatedly constructing sys.argv 3 times is not elegant to me.

Verified locally

with 2 new options
without 2 new options
with only --athlete
with only --min_grid_distance // same behavior with without 2 new options is as expected

Ran black . but only kept changes by this commit.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
running-page	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2024 0:58am

yihong0618 commented 1 week ago

thanks