search

yihui / animation

A gallery of animations in statistics and utilities to create animations
https://yihui.org/animation/
205 stars 59 forks source link

pdftk used to fail if special characters are included in filenames #110

Closed oganm closed 6 years ago

oganm commented 6 years ago

Also it is not part of this pull request but instead of demanding pdftk address from the user it can be automatically detected

    if(Sys.info()['sysname'] =='Windows'){
        path = system2('where','pdftk',stdout = TRUE)
    } else {
        path = system2('which','pdftk',stdout = TRUE)
    }
    animation::ani.options(pdftk = path)
yulijia commented 6 years ago

Thank you for your contribution and good example!

yihui commented 6 years ago

Should we just use shQuote()? I confess I haven't read my own source code in this package for several years...

yulijia commented 6 years ago

@yihui you are right, I will update it.