search

yihui / knitr

A general-purpose tool for dynamic report generation in R
https://yihui.org/knitr/
2.38k stars 876 forks source link

Stata engine - more specific cleanup of files #2210

Closed Hemken closed 1 year ago

Hemken commented 1 year ago

I would suggest the changes here, changing a few "." wildcards to "\." literals dots. This was code a wrote years ago, when I was new to regex!

An alternative would be to simply drop this Stata output file cleanup altogether, and allow it to be handled in the Statamarkdown package.

cderv commented 1 year ago

An alternative would be to simply drop this Stata output file cleanup altogether, and allow it to be handled in the Statamarkdown package.

Thanks I am happy to merge this as is, and we could then adapt the support of Stata here by the Statamarkdown. Do we need to do anything specific for this ?

Hemken commented 1 year ago

Nothing else need be done.