search

yihui / xfun

Miscellaneous R functions
https://yihui.org/xfun/
Other
135 stars 28 forks source link

crandalf improvment to trigger build #60

Closed cderv closed 2 years ago

cderv commented 2 years ago

This PR now use gh workflow run rev-check.yaml --ref <branch> to manually trigger a workflow in the branch.

This will always work even for old PR with deleted runs, which was not the case before.

crandalf_id() does not seems useful anymore but I did not remove it.

I got other config issues on Windows and various things, but nothing really that should be improved in xfun directly I think. I'll PR other things if needed.

This closes https://github.com/yihui/crandalf/issues/23

cderv commented 2 years ago

This workflow was manually triggered using xfun from this branch: https://github.com/yihui/crandalf/actions/runs/1559557481

Should we add a bullet to NEWS for this ?

cderv commented 2 years ago

I think this is good this time.

cderv commented 2 years ago

Only drawback with this approach is that we loose information on the action pane

image

I did not find a way to have information change on this page by API or else. We can set inputs but they are only useful inside the workflow and I can't use them in the name of the workflow I think. (Maybe I should try though ? 🤔 )

Maybe be can retrieve the run ID to build the URL and print it back in R console so that we have a link direct on the action page ?

Otherwise we can revert back and

  1. Try first the previous method
  2. Use this new one only if the first try fails

But I think using workflow_dispatch is cleaner / better than a rerun of a previous workflow

Anyway, I wanted to share this thought.

yihui commented 2 years ago

I'm fine with this drawback.

Maybe be can retrieve the run ID to build the URL and print it back in R console so that we have a link direct on the action page ?

Feel free to do that if it's easy enough. Thanks!