search

yihui / xfun

Miscellaneous R functions
https://yihui.org/xfun/
Other
141 stars 28 forks source link

Update GHA workflow #64

Closed cderv closed 2 years ago

cderv commented 2 years ago

using same as other repo. Test coverage workflow has been moved as a step in R CMD Check to save some runs

cderv commented 2 years ago

I noticed that gregexec is from 4.1.0 https://github.com/yihui/xfun/blob/837960ee4f57c7dd52bd2843c9075d3f939ac8d0/R/github.R#L31 Maybe adding a Depends field in DESCRIPTION would be necessary if we keep this min requirement. But for one function maybe just warning/failing nicely if this function is used with R before R 4.1.0 ? (If possible)

That does not seem to be an issue though.

Also, I removed R_REMOTES_NO_ERRORS_FROM_WARNINGS: true because it should be controlled in with a parameter for check-r-package workflow. I can add error-on: "error" as oldrel-3 is failing because of that but is this something to be fixed somehow ? https://github.com/yihui/xfun/runs/5468254560?check_suite_focus=true#step:6:64

Seems like something is wrong 🤔 (didn't look closely as I need to go)

yihui commented 2 years ago

I'll deal with the gregexec issue. Thanks!

cderv commented 2 years ago

I let this PR like it then. You can remove any oldrel that you don't want. For the on error issue you can add 

diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
index 952369b..c5842be 100644
--- a/.github/workflows/R-CMD-check.yaml
+++ b/.github/workflows/R-CMD-check.yaml
@@ -53,8 +53,10 @@ jobs:

       - uses: r-lib/actions/check-r-package@v2
         with:
+          error-on: "error"
           upload-snapshots: true

if you don't want error on R CMD CHECK warning for this repo.