Closed bastistician closed 1 year ago
is_ascii
should probably also test whether the converted string differs from the input.
Good idea. Done. Thank you!
Thanks, I can confirm that the package now passes the tests on my "--extra-arch" check system.
On my Alpine Linux check system, I see
A minimal reproducible example for the failing test follows:
So on musl the iconv call does not give NA as expected by
is_ascii
. This behaviour is mentioned inhelp(iconv)
:This means that testing for an NA result of this conversion is generally insufficient.
is_ascii
should probably also test whether the converted string differs from the input.