Closed Brice1827 closed 2 weeks ago
I will definitely go through the PR, but at the outset it seems like you have added completely new function doing the same thing, only a different PK name. If am correct, why not add pk attribute with default value 'id' so that we have same function
I wanted to keep the current way of working for uses already in progress, so as not to break anything (i.e. to avoid having to modify the controller).
I wanted to keep the current way of working for uses already in progress
You can add third parameter name pkeyName
or something which defaults to 'id'
which will not affect currently existing codebases
OK rejet PR, i will make another monday
You can do the changes and push a commit to same PR
I think all is well. Can you add a line on changelog before it can be merged? Sorry for late reply.
@Brice1827 thanks for your time and efforts.
Create function createMultiplePkNotId for cases when table pk is not 'id'