search

yii2-extensions / dynamicform

Yii2 Dynamic form widget for cloning form elements in a nested manner while maintaining accessibility.
Other
3 stars 1 forks source link

Issue 2 #3

Closed Brice1827 closed 2 weeks ago

Brice1827 commented 2 months ago

Create function createMultiplePkNotId for cases when table pk is not 'id'

mtangoo commented 2 months ago

I will definitely go through the PR, but at the outset it seems like you have added completely new function doing the same thing, only a different PK name. If am correct, why not add pk attribute with default value 'id' so that we have same function

Brice1827 commented 2 months ago

I wanted to keep the current way of working for uses already in progress, so as not to break anything (i.e. to avoid having to modify the controller).

mtangoo commented 2 months ago

I wanted to keep the current way of working for uses already in progress

You can add third parameter name pkeyName or something which defaults to 'id' which will not affect currently existing codebases

Brice1827 commented 2 months ago

OK rejet PR, i will make another monday

mtangoo commented 2 months ago

You can do the changes and push a commit to same PR

mtangoo commented 3 weeks ago

I think all is well. Can you add a line on changelog before it can be merged? Sorry for late reply.

mtangoo commented 2 weeks ago

@Brice1827 thanks for your time and efforts.