return vs echo - Githubissues

yii2mod / yii2-chosen-select

Select Widget based on Chosen jQuery plugin

MIT License

14 stars 7 forks source link

return vs echo #11

Closed nadar closed 4 years ago

nadar commented 4 years ago

Whats the reason to use echo instead of return?

https://github.com/yii2mod/yii2-chosen-select/blob/master/ChosenSelect.php#L66

I think this is considered bad practice and also disables the option to passed the content into a variable. Therefore i would suggest register the assets before and then return the content return Html::...

Would you accept a PR or its there a specific reason to do so?

nadar commented 4 years ago

bump 😄

nadar commented 4 years ago

:crying_cat_face:

ihorchepurnyi commented 4 years ago

Hi @nadar, I'm sorry for late reply. Could you please create a PR for it?