yiiext / imperavi-redactor-widget

Imperavi Redactor WYSIWYG widget (OEM-licensed for Yii)
http://yiiext.github.com/extensions/imperavi-redactor-widget/
Other
406 stars 152 forks source link

Setting plugin baseUrl broken since a7fdd00 #30

Closed ghost closed 11 years ago

ghost commented 11 years ago

Commit a7fdd00ce5ac164acd0cc7b6129efd1bf95ee2a7 seems to have broken setting a custom baseUrl for redactor plugins.

From the documentation:

// You can set base path to assets
'basePath' => 'application.components.imperavi.my_plugin',
// or url, basePath will be ignored.

However,

if (!isset($plugin['baseUrl'], $plugin['basePath']))

evaluates to true and overwrites $plugin['baseUrl'] unless both baseUrl and basePath are set.

samdark commented 11 years ago

@slavcodev can you check this one? Thanks.

slavcodev commented 11 years ago

Fix in 9304ebc