yiiext / yii2-yii-bridge

Yii bridge between v1.1.x and v2.0
23 stars 9 forks source link

Update README.md #12

Closed icevita closed 9 years ago

icevita commented 9 years ago

fixed to work

slavcodev commented 9 years ago

Thanks :+1:

enriquemolinari commented 9 years ago

Hello! quick question... on the home page, usage section, when you say:

// Create old application, but NOT run it! $gaffer = Yii::createWebApplication($v1AppConfig);

// Create new application and run. Have fun! $application = new yii\web\Application($v2AppConfig);

Instead of: $gaffer->run(); should not be $application->run(); ??

Or if not, then the comments can be changed. And then is the Yii 1 framework who manage the request, right?

Thanks

slavcodev commented 9 years ago

Yes, you're right. Thanks. Fixed https://github.com/yiiext/yii2-yii-bridge/commit/d7e2cf980a6da731642ae6d6a4efe9d8561abdf0