The method allPopulate in ActiveQuery will execute populate twice during execution

yiisoft / active-record

Active Record database abstraction layer

https://www.yiiframework.com/

BSD 3-Clause "New" or "Revised" License

70 stars 29 forks source link

The method allPopulate in ActiveQuery will execute populate twice during execution #289

Closed niqingyang closed 9 months ago

niqingyang commented 10 months ago

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	✔️/❌
Fixed issues	The method allPopulate in ActiveQuery will execute populate twice during execution #286

what-the-diff[bot] commented 10 months ago

PR Summary

Simplification of 'allPopulate()' method in ActiveQuery.php The previous version of the allPopulate() method used to populate rows and carry out additional checks to ensure they weren't empty. With this update, this process got simpler as we replaced this logic with a direct call to the all() method for a more efficient execution.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a9097f1) 87.70% compared to head (f95a71d) 87.67%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #289 +/- ## ============================================ - Coverage 87.70% 87.67% -0.03% + Complexity 595 594 -1 ============================================ Files 7 7 Lines 1326 1323 -3 ============================================ - Hits 1163 1160 -3 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

niqingyang commented 9 months ago

Sorry for the long response. Perhaps we should remove the method as this is the same as .allPopulate()``all()

Related with:

Restore Query::one interface db#798

Yes, it looks better this way