Add `ArrayrHelper::renameKey()`

yiisoft / arrays

Yii Array Helper

https://www.yiiframework.com/

BSD 3-Clause "New" or "Revised" License

52 stars 28 forks source link

Add `ArrayrHelper::renameKey()` #149

Closed vjik closed 8 months ago

vjik commented 8 months ago

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌

what-the-diff[bot] commented 8 months ago

PR Summary

Introduction of replaceKey method in ArrayHelper class We now have a new functionality available in our ArrayHelper class. This new method, replaceKey, lets us swap one key in an array with another, providing us with more flexibility in manipulating array data.
Inclusion of Test Case for replaceKey method To ensure that our new function is performing as expected, we've added an accompanying test case. This is contained within the new ReplaceKeyTest.php file, ensuring we can reliably validate the correct behaviour of the replaceKey utility.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.76%. Comparing base (228e703) to head (2a5593c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #149 +/- ## ========================================= Coverage 99.76% 99.76% - Complexity 212 214 +2 ========================================= Files 4 4 Lines 422 429 +7 ========================================= + Hits 421 428 +7 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samdark commented 8 months ago

Should we name it renameKey()?

vjik commented 8 months ago

Should we name it renameKey()?

I don't know. For me both names are OK.

samdark commented 8 months ago

I'd make it renameKey().