search

yiisoft / classifier

Classifier traverses file system to find classes by a certain criteria.
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Token classifier & refactor filters #41

Closed rustamwin closed 1 year ago

rustamwin commented 1 year ago
Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues #39
codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2db3db7) 100.00% compared to head (527cdce) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## refactoring #41 +/- ## ================================================ Coverage 100.00% 100.00% - Complexity 24 73 +49 ================================================ Files 2 8 +6 Lines 60 175 +115 ================================================ + Hits 60 175 +115 ``` | [Files](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft) | Coverage Δ | | |---|---|---| | [src/AbstractClassifier.php](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0Fic3RyYWN0Q2xhc3NpZmllci5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Filter/ClassAttributes.php](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0ZpbHRlci9DbGFzc0F0dHJpYnV0ZXMucGhw) | `100.00% <100.00%> (ø)` | | | [src/Filter/ClassImplements.php](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0ZpbHRlci9DbGFzc0ltcGxlbWVudHMucGhw) | `100.00% <100.00%> (ø)` | | | [src/Filter/SubclassOf.php](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0ZpbHRlci9TdWJjbGFzc09mLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/Filter/TargetAttribute.php](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL0ZpbHRlci9UYXJnZXRBdHRyaWJ1dGUucGhw) | `100.00% <100.00%> (ø)` | | | [src/NativeClassifier.php](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL05hdGl2ZUNsYXNzaWZpZXIucGhw) | `100.00% <100.00%> (ø)` | | | [src/ReflectionFile.php](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1JlZmxlY3Rpb25GaWxlLnBocA==) | `100.00% <100.00%> (ø)` | | | [src/TokenizerClassifier.php](https://app.codecov.io/gh/yiisoft/classifier/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=yiisoft#diff-c3JjL1Rva2VuaXplckNsYXNzaWZpZXIucGhw) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xepozz commented 1 year ago

Please don't forget to compare benchmarks

rustamwin commented 1 year ago

ℹ️ The classifier now also finds interfaces, traits and enums.

samdark commented 1 year ago

@rustamwin https://github.com/yiisoft/classifier/pull/41#issuecomment-1772970208?

rustamwin commented 1 year ago

@rustamwin https://github.com/yiisoft/classifier/pull/41#issuecomment-1772970208?

I will do it within 1-2 days.

rustamwin commented 1 year ago

Benchmark results here: https://github.com/yiisoft/classifier/pull/38#issuecomment-1782268810