yiisoft / data-cycle

Data adapter for Cycle ORM
https://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
7 stars 2 forks source link

Declaration of Yiisoft\Data\Cycle\Reader\EntityReader::withLimit(int $limit): static must be compatible with Yiisoft\Data\Reader\LimitableDataInterface::withLimit(?int $limit): static #29

Closed rossaddison closed 1 hour ago

rossaddison commented 2 hours ago

What steps will reproduce the problem? Running rossaddison/invoice

What is the expected result? Clean run

What do you get instead? The above error

Additional info

Q A
Version 1.0.?
PHP version 8.3
Operating system Windows 11

Yiisoft\ErrorHandler\Exception\ErrorException: Declaration of Yiisoft\Data\Cycle\Reader\EntityReader::withLimit(int $limit): static must be compatible with Yiisoft\Data\Reader\LimitableDataInterface::withLimit(?int $limit): static in C:\wamp64\www\invoice\vendor\yiisoft\data-cycle\src\Reader\EntityReader.php:79 Stack trace:

0 [internal function]: Yiisoft\ErrorHandler\ErrorHandler->Yiisoft\ErrorHandler{closure}()

1 {main}

rossaddison commented 2 hours ago

Missing a question mark '?' before int.

samdark commented 1 hour ago

Already fixed. Do composer update. https://github.com/yiisoft/data-cycle/blob/master/src/Reader/EntityReader.php#L72

rossaddison commented 49 minutes ago

Problem 1