Closed Tigrov closed 11 months ago
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | - |
Database Connection Update in OracleFactory.php
The database we connect to in our software has been updated. Before, we were connecting to a different database. Now, our software directly connects to a database named localhost:1521/XE
.
Modification to Table Deletion Method
Previously, our software deleted tables with the dropTable
method, which sometimes left behind unwanted data or constraints connected to the table. The change made ensures that all related elements to that table are destroyed, making it a complete and clean removal of the table. This avoids clutter and potential errors in the future.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5f8b93d
) 99.80% compared to head (336477f
) 99.80%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why GitHub Actions work without this changes, but don't work locally?
I have locally Oracle Database 21c XE (Express Edition)
This does not work if not specify DB service name XE
'oci:dbname=localhost:1521/XE;charset=AL32UTF8',
In some cases during development there were problems with dependent CONSTRAINTS
when dropping tables.
Now it works without changes, but in the future may encounter the same problem.
GitHub Actions always have clear DB, but locally it could has old objects, e.g. after an exception.