yiisoft / db-migration

The package implementing migration for yiisoft/db.
https://www.yiiframework.com/
BSD 3-Clause "New" or "Revised" License
29 stars 16 forks source link

Fix Oracle tests running locally #232

Closed Tigrov closed 11 months ago

Tigrov commented 12 months ago
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -
what-the-diff[bot] commented 12 months ago

PR Summary

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5f8b93d) 99.80% compared to head (336477f) 99.80%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #232 +/- ## ========================================= Coverage 99.80% 99.80% Complexity 309 309 ========================================= Files 19 19 Lines 1014 1014 ========================================= Hits 1012 1012 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tigrov commented 11 months ago

Why GitHub Actions work without this changes, but don't work locally?

  1. I have locally Oracle Database 21c XE (Express Edition) This does not work if not specify DB service name XE 'oci:dbname=localhost:1521/XE;charset=AL32UTF8',

  2. In some cases during development there were problems with dependent CONSTRAINTS when dropping tables. Now it works without changes, but in the future may encounter the same problem. GitHub Actions always have clear DB, but locally it could has old objects, e.g. after an exception.